Extra volumes and mounts #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vittorio Canilli <vittorio.canilli@gmail.com>
Signed-off-by: Vittorio Canilli <vittorio.canilli@gmail.com>
Contributor
Author
|
Hello @alexnuttinck, any feedback about this PR? |
Member
|
Hello @vittoriocanilli, sorry for the wait. It looks good to me, thanks. I merge your PR now. |
Contributor
Author
|
Hello @alexnuttinck, thanks for taking care of it! I look forward to a new release, so I can finally use the extra volumes 😄 |
Member
|
@vittoriocanilli the release is already available: https://github.com/IMIO/helm-charts/blob/gh-pages/plausible-analytics/plausible-analytics-0.4.1.tgz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the possibility to define additional volumes and their mounts to the
plausible-analyticscontainer: in my case it is useful to create a secret with all environment variables (used in thesecret.existingSecretvalue) with Secret provider class for Azure Key vaults, which requires an additional volume in the deployment with a specific path.Additionally, I have moved the optional
database-cavolume mount from thewait-for-clickhouseinit container to thewait-for-postgresinit container, as the certificates are needed for PostgreSQL.Which issue this PR fixes
trust-manager#12Special notes for your reviewer:
Unfortunately I have was done with the PR before reading the contribution guidelines, so I did not add a line to every git commit message, to DCO-sign them. In a second moment I have edited my commit messages to DCO-sign them. Please let me know if it is acceptable.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]